Add help note when using type in place of const #75611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
JulianKnodt
force-pushed
the
cg_enum_err
branch
2 times, most recently
from
1ea9ffc
to
b3481d0
Compare
lcnr
reviewed
Aug 19, 2020
lcnr
reviewed
Aug 20, 2020
lcnr
reviewed
Aug 20, 2020
JulianKnodt
force-pushed
the
cg_enum_err
branch
from
90071ef
to
8d32a26
Compare
lcnr
reviewed
Aug 21, 2020
lcnr
reviewed
Aug 21, 2020
JulianKnodt
force-pushed
the
cg_enum_err
branch
from
f232056
to
c70d1f7
Compare
lcnr
reviewed
Aug 21, 2020
| help: If this generic argument was intended as a const parameter, try surrounding it with braces: | ||
| | | ||
| LL | test::<{ CompileFlag::A }>(); | ||
| | ^ ^ |
There was a problem hiding this comment.
awesome ✨
will try and review the actual code changes next week.
|
☔ The latest upstream changes (presumably #75797) made this pull request unmergeable. Please resolve the merge conflicts. |
JulianKnodt
force-pushed
the
cg_enum_err
branch
from
c70d1f7
to
bdcbadb
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
JulianKnodt
force-pushed
the
cg_enum_err
branch
5 times, most recently
from
b11589d
to
4a21039
Compare
|
☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts. |
JulianKnodt
force-pushed
the
cg_enum_err
branch
from
4a21039
to
698ef42
Compare
lcnr
reviewed
Aug 31, 2020
JulianKnodt
force-pushed
the
cg_enum_err
branch
2 times, most recently
from
6abde86
to
714c59b
Compare
lcnr
reviewed
Sep 3, 2020
JulianKnodt
force-pushed
the
cg_enum_err
branch
from
714c59b
to
96bb2c8
Compare
|
@bors r+ |
|
📌 Commit 96bb2c8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 16, 2020
improve type const mismatch errors Doesn't completely remove `check_generic_arg_count` as that would have required some more complex changes but instead checks type and const params in only one step. Also moved the help added by `@JulianKnodt` in rust-lang#75611 to `generic_arg_mismatch_err`. r? `@varkor` cc `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small help note when it might be possible that wrapping a parameter in braces might resolve the issue of having a type where a const was expected.
Currently, I am displaying the
HirId, and I'm not particularly sure where to get the currently displayed path(?).r? @lcnr